@ngrx/component: Better typing for LetDirective and PushPipe
#3344
Assignees
Labels
Comments
3 tasks
brandonroberts
pushed a commit
that referenced
this issue
May 28, 2022
BREAKING CHANGES:
1. The context of `LetDirective` is strongly typed when `null` or
`undefined` is passed as input.
BEFORE:
```html
<p *ngrxLet="null as n">{{ n }}</p>
<p *ngrxLet="undefined as u">{{ u }}</p>
```
- The type of `n` is `any`.
- The type of `u` is `any`.
AFTER:
```html
<p *ngrxLet="null as n">{{ n }}</p>
<p *ngrxLet="undefined as u">{{ u }}</p>
```
- The type of `n` is `null`.
- The type of `u` is `undefined`.
---
2. Arrays, iterables, generator functions, and readable streams are
not treated as observable-like inputs anymore. To keep the same behavior
as in v13, convert the array/iterable/generator function/readable stream
to observable using the `from` function from the `rxjs` package
before passing it to the `LetDirective`/`PushPipe`.
BEFORE:
```ts
@component({
template: `
<p *ngrxLet="numbers as n">{{ n }}</p>
<p>{{ numbers | ngrxPush }}</p>
`,
})
export class NumbersComponent {
numbers = [1, 2, 3];
}
```
AFTER:
```ts
@component({
template: `
<p *ngrxLet="numbers$ as n">{{ n }}</p>
<p>{{ numbers$ | ngrxPush }}</p>
`,
})
export class NumbersComponent {
numbers$ = from([1, 2, 3]);
}
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
LetDirective: whennullorundefinedis passed, the type of value isany.PushPipe: there is no signature oftransformmethod that can accept unionObservable<...> | nullorObservable<...> | undefined.The text was updated successfully, but these errors were encountered: