Added support to give name for store dev tool #517

rupeshtiwari · 2017-10-21T13:04:24Z

This is the changes to put name on store dev tool configuration object for the issue #463

coveralls · 2017-10-21T13:07:30Z

Coverage increased (+0.006%) to 92.546% when pulling e0b05f4 on roopkt:dev-tool-name into 565389a on ngrx:master.

coveralls · 2017-10-23T14:04:41Z

Coverage increased (+0.006%) to 92.546% when pulling 026d4d2 on roopkt:dev-tool-name into 565389a on ngrx:master.

rupeshtiwari · 2017-10-24T02:11:57Z

Finished passing name to devtools fixes #463

rupeshtiwari · 2017-10-27T07:24:43Z

Hi @brandonroberts I updated this pull request with my latest changes.

coveralls · 2017-10-27T07:27:12Z

Coverage decreased (-0.006%) to 92.534% when pulling 4e8b793 on roopkt:dev-tool-name into 565389a on ngrx:master.

coveralls · 2017-10-27T07:33:49Z

Coverage decreased (-0.05%) to 92.488% when pulling 7a891a7 on roopkt:dev-tool-name into 565389a on ngrx:master.

coveralls · 2017-10-28T16:18:06Z

Coverage decreased (-0.006%) to 92.488% when pulling 0bb84da on roopkt:dev-tool-name into ab7de5c on ngrx:master.

rupeshtiwari · 2017-10-28T16:43:15Z

Hi @brandonroberts ,
I fixed code merge issue as well. Please check if the implementation or the fix for the issue #463 is correct.

brandonroberts · 2017-10-31T01:06:35Z

@roopkt the changelog shouldn't be included in your changes. Please verify that your changes change the name in the extension also.

rupeshtiwari · 2017-11-02T14:12:53Z

Hi @brandonroberts thanks for giving me the direction to pass options to send method. I am planning to inject then STORE_DEVTOOLS_CONFIG into DevtoolsExtension so that we can always pass the entire option in send method. This is one potential solution that I think of.

I even wanted to validate by running example app however unfortunately when I run
yarn run eample:star I always get error NONEMPTY dir related error. I tried deleting '../platform/dist' folder manually still when I run the start script I get error at some point while "Copying type definition files" step. I event tried opening new command terminal to execute still same issue. Have you encountered this issue is there any wise workaround of this.

Example of error:

× Copying type definition files
{ Error: ENOTEMPTY: directory not empty, rmdir '...\platform\dist\packages\enti
ty'
  errno: -4051,
  code: 'ENOTEMPTY',
  syscall: 'rmdir',
  path: '...\\platform\\dist\\packages\\entity' }
error Command failed with exit code 1.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

This error is big problem and wasting lots of time. I want to know the process of testing changes. When I do some changes in any module in ngrx then for testing the same in example app what is my step ? I tried below close vscode, delete platform/dist folder open vscode and run yarn run example:start but it shows above error.

…ts to verify its really ending options to redux dev tool extension ngrx#517

coveralls · 2017-11-02T20:49:29Z

Coverage increased (+0.3%) to 92.813% when pulling fe9d0bb on roopkt:dev-tool-name into ab7de5c on ngrx:master.

rupeshtiwari · 2017-11-02T21:04:13Z

Hey @brandonroberts
I pushed one more change-set this time I verified the ReduxDevToolExtension name is indeed changing. 👍

brandonroberts · 2017-11-08T02:12:32Z

CHANGELOG.md

@@ -1,6 +1,204 @@
-# Changelogs


This file should not be included in the changes

brandonroberts · 2017-11-08T02:15:17Z

modules/store-devtools/src/instrument.ts

@@ -64,12 +64,16 @@ export function noMonitor(): null {
  return null;
 }

+export const DEFAULT_NAME = 'ngrx-store-devtool-instance';


Change to NgRx Store DevTools

I changed the name to NgRx Store DevTools

brandonroberts · 2017-11-08T02:16:06Z

modules/store-devtools/src/instrument.ts

 export function createConfig(
  _options: StoreDevtoolsOptions
 ): StoreDevtoolsConfig {
-  const DEFAULT_OPTIONS: StoreDevtoolsConfig = {
+  const DEFAULT_OPTIONS: Partial<StoreDevtoolsConfig> = {


Why is this a partial?

I removed the partial from here.

brandonroberts · 2017-11-08T02:17:00Z

CHANGELOG.md

@@ -1,6 +1,204 @@
-# Changelogs


The changelog should not be included in these changes. We'll generate a changelog in the next release

Thanks for explaination

coveralls · 2017-11-08T23:21:20Z

Coverage increased (+0.3%) to 92.813% when pulling 83088f2 on roopkt:dev-tool-name into ab7de5c on ngrx:master.

brandonroberts · 2017-11-13T03:27:57Z

Thanks!

rupeshtiwari added 2 commits October 21, 2017 08:40

added action action and state sanitizer ngrx#494

3b6da60

adding support for name in storedevtools ngrx#463

e0b05f4

brandonroberts mentioned this pull request Oct 22, 2017

added action and state sanitizer to store dev tool #494 #516

Closed

worked on passing confi to devtool ngrx#517

026d4d2

updating the pull request ngrx#517

4e8b793

resolved merge issue for pull request ngrx#517

7a891a7

rupeshtiwari added 2 commits October 27, 2017 03:36

Merge branch 'master' into dev-tool-name

a522aca

fixing merge issue ngrx#517

0bb84da

passing devtool options to the ReduxDevToolExtension add new spec tes…

fe9d0bb

…ts to verify its really ending options to redux dev tool extension ngrx#517

brandonroberts requested changes Nov 8, 2017

View reviewed changes

worked on the feedback by @brandonroberts for ngrx#517

83088f2

brandonroberts approved these changes Nov 13, 2017

View reviewed changes

brandonroberts merged commit 00be3d1 into ngrx:master Nov 13, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added support to give name for store dev tool #517

Added support to give name for store dev tool #517

rupeshtiwari commented Oct 21, 2017

coveralls commented Oct 21, 2017

coveralls commented Oct 23, 2017

rupeshtiwari commented Oct 24, 2017

rupeshtiwari commented Oct 27, 2017

coveralls commented Oct 27, 2017

coveralls commented Oct 27, 2017

coveralls commented Oct 28, 2017

rupeshtiwari commented Oct 28, 2017

brandonroberts commented Oct 31, 2017

rupeshtiwari commented Nov 2, 2017 •

edited

Loading

coveralls commented Nov 2, 2017

rupeshtiwari commented Nov 2, 2017

brandonroberts Nov 8, 2017

rupeshtiwari Nov 8, 2017

brandonroberts Nov 8, 2017

rupeshtiwari Nov 8, 2017

brandonroberts Nov 8, 2017

rupeshtiwari Nov 8, 2017

brandonroberts Nov 8, 2017

rupeshtiwari Nov 8, 2017

coveralls commented Nov 8, 2017

brandonroberts commented Nov 13, 2017

Added support to give name for store dev tool #517

Added support to give name for store dev tool #517

Conversation

rupeshtiwari commented Oct 21, 2017

coveralls commented Oct 21, 2017

coveralls commented Oct 23, 2017

rupeshtiwari commented Oct 24, 2017

rupeshtiwari commented Oct 27, 2017

coveralls commented Oct 27, 2017

coveralls commented Oct 27, 2017

coveralls commented Oct 28, 2017

rupeshtiwari commented Oct 28, 2017

brandonroberts commented Oct 31, 2017

rupeshtiwari commented Nov 2, 2017 • edited Loading

coveralls commented Nov 2, 2017

rupeshtiwari commented Nov 2, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Nov 8, 2017

brandonroberts commented Nov 13, 2017

rupeshtiwari commented Nov 2, 2017 •

edited

Loading