added action and state sanitizer to store dev tool #494

[rupeshtiwari]

Please merge this changes which supports action and state sanitizer to the store dev tool. Let me know if there is any improvement required.

[coveralls]

Coverage decreased (-0.1%) to 92.405% when pulling 3b6da60 on roopkt:master into 565389a on ngrx:master.

[brandonroberts]

Hey @roopkt, this PR and #517 is more involved than just adding a key to the config object. You'll need to pass the config options to the extension itself when sending messages.

[rupeshtiwari]

Sure I will update , thanks!

[rupeshtiwari]

Finished passing state and action sanitizer to devtools. Fixes #494

[aboyton]

I'm not sure that you updated the pull request with your latest changes.

[rupeshtiwari]

Hi @aboyton I am not sure how to update the pull request. I am going to create another local branch and try to check in again with putting the Pull Request number #516 in the comment hope that will update the pull request. If that is incorrect, please guide me how to update this pull request with my latest changes? Also I am not able to take the latest from the upstream ngrx/platform branch therefore every time I check in I get a merge issue.
Normally when we rebase from upstream it should pull latest from the ngrx/platform to my forked branch but when I try to rebase it gives me access denied error.

git fetch upstream

My upstream is https://github.com/ngrx/platform.git and above command gives me below error. Therefore I have to do manual merge I go a literally take the copy of ngrx/platform code and merge locally in my vsCode. Please suggest is there any better way to take latest from upstream to my local forked branch ?

Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists

[aboyton]

I'm no expert at this, but I generally follow the advice that's from this answer. https://stackoverflow.com/questions/25545613/how-can-i-push-to-my-fork-from-a-clone-of-the-original-repo

First I'd set a new remote called roopkt (or whatever name you'd prefer).

git remote add roopkt https://github.com/roopkt/platform.git

Then you can push your changes to your new remote with git push roopkt master (assuming you're working in master which I think you are). Once you've pushed you should see your changes in https://github.com/roopkt/platform

The pull request should then automatically update with the latest changes.

You shouldn't need to pull from master for making this diff, but if you wanted to personally I'd do git pull --rebase which would pull from master and then "rebase" your changes on top.

[brandonroberts]

The options should be passed to the extension. Adding them to the config isn't enough

[rupeshtiwari]

Hey @brandonroberts ,
Implemented the options changes where it is passed to the extension now.

[aboyton]

Are your most recent changes in the branch roopkt:devtool-sanitizers (https://github.com/roopkt/platform/tree/devtool-sanitizers)? This pull request is from roopkt:master which hasn't been updated in a while.

[rupeshtiwari]

Hey @aboyton
Yes I created new branch for this pull request roopkt:devtool-sanitizers.
Please let me know is it okay or I have to do anything else.

[aboyton]

I don't know a way of changing your pull request to compare against a different branch. It's probably simplest to go to https://github.com/roopkt/platform/tree/devtool-sanitizers and create a new pull request.

[rupeshtiwari]

Hi @aboyton I created new pull request #544 Thanks, Rupesh Kumar Tiwari

[brandonroberts]

Closed in favor of #544