Added support for actionSanitiser and stateSanitiser in @ngrx/store-devtools #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@roopkt please fix merge conflicts and we'll land this PR. |
|
@roopkt conflicts still remain. See the details from the failed tests |
|
@brandonroberts I am still working on the merge. I have question when are we planing to review #524 pull request. |
|
Hey @brandonroberts |
brandonroberts
requested changes
Nov 14, 2017
| options.actionSanitizer = sanitizer; | ||
| expect(options.actionSanitizer).toEqual(sanitizer); | ||
| }); | ||
| it('can be initialized with stateSanitizer', () => { |
There was a problem hiding this comment.
Add a line in between these tests
| function stateSanitizer(state: any, index: number): any { | ||
| return state; | ||
| } | ||
| options.actionSanitizer = stateSanitizer; |
There was a problem hiding this comment.
Shouldn't this be stateSanitizer?
| function myActionSanitizer() { | ||
| return { type: 'sanitizer' }; | ||
| } | ||
| function myStateSanitizer() { |
There was a problem hiding this comment.
Add a line in between these functions
brandonroberts
approved these changes
Nov 16, 2017
|
Thanks for doing (and merging) this. Are you planning on a patch release anytime soon with this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix to pass state and action sanitizer to redux dev tool extensions for #494.