-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Router resolve #524
Router resolve #524
Conversation
Finished creating ROUTER_RESOLVE_END action dispatching. Fixes #358 |
modules/store-devtools/src/config.ts
Outdated
@@ -1,4 +1,4 @@ | |||
import { ActionReducer } from '@ngrx/store'; | |||
import { ActionReducer, Action } from '@ngrx/store'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an unused import?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes and I am doing another checkin to remove those unused namespaces.
Below are required only. Basically this file does not need to be changed.
import { InjectionToken } from '@angular/core';
import { ActionReducer } from '@ngrx/store';
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please undo any changes to this file. This is my mistake.
@royling @brandonroberts Hi I resolved the merge issues and also removed the redundant namespace all checked in. |
Hi @brandonroberts is there any plan to review my pull request ? |
Hi @brandonroberts |
Left a comment here about this feature: #358 (comment) |
Worked on creating ROUTER_RESOLVE_END action for the issue #358