feat(Effects): stringify action on invalid action #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonroberts
requested changes
Aug 1, 2018
| @@ -57,3 +57,11 @@ function getEffectName({ | |||
|
|
|||
| return `"${sourceName}.${propertyName}${isMethod ? '()' : ''}"`; | |||
| } | |||
|
|
|||
| function stringify(action: any) { | |||
There was a problem hiding this comment.
Type to Action | null | undefined and add a test
Message before: ERROR Error: Effect "AuthEffects.login$" dispatched an invalid action: [object Object]
Message after: ERROR Error: Effect "AuthEffects.login$" dispatched an invalid action: [{"payload":{"user":{"name":"User"}},"type":"[Auth] Login Success"}]
timdeschryver
force-pushed
the
pr/effects-stringify-action
branch
from
9a95cfc to
8d322d9
Compare
brandonroberts
approved these changes
Aug 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To have a more meaningful error when the effects retrieve an invalid action we could stringify the action. That way the dev would immediately know which action is wrong, this could be helpful for newcomers.
Message before:
Message after: