Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schematics): Remove peer dependencies on Angular DevKit #1222

Merged
merged 1 commit into from
Aug 1, 2018
Merged

fix(schematics): Remove peer dependencies on Angular DevKit #1222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions modules/schematics/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,5 @@
"ng-update": {
"packageGroup": "NG_UPDATE_PACKAGE_GROUP",
"migrations": "NG_UPDATE_MIGRATIONS"
},
"peerDependencies": {
"@angular-devkit/core": "NG_DEVKIT_VERSION",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the only place where we were using NG_DEVKIT_VERSION, thus we could also remove it from defaults.bzl.

"@angular-devkit/schematics": "NG_DEVKIT_VERSION"
}
}
2 changes: 0 additions & 2 deletions tools/defaults.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ load("@build_bazel_rules_nodejs//:defs.bzl",
DEFAULT_TSCONFIG = "//:tsconfig.json"
NG_VERSION = "^6.0.0"
RXJS_VERSION = "^5.6.0-forward-compat.0 || ^6.0.0"
NG_DEVKIT_VERSION = "^0.6.0"
NG_UPDATE_MIGRATIONS = "./migrations/migration.json"
MODULE_SCHEMATICS_COLLECTION = "./schematics/collection.json"

Expand All @@ -30,7 +29,6 @@ PKG_GROUP_REPLACEMENTS = {
"\"NG_UPDATE_PACKAGE_GROUP\"": """[
%s
]""" % ",\n ".join(["\"%s\"" % s for s in NGRX_SCOPED_PACKAGES]),
"NG_DEVKIT_VERSION": NG_DEVKIT_VERSION,
"NG_UPDATE_MIGRATIONS": NG_UPDATE_MIGRATIONS,
"MODULE_SCHEMATICS_COLLECTION": MODULE_SCHEMATICS_COLLECTION,
}
Expand Down