Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RouterStore): don't navigate on NagivationStart #1392

Merged
merged 1 commit into from
Oct 31, 2018

Conversation

timdeschryver
Copy link
Member

@timdeschryver timdeschryver commented Oct 31, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1373

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

Closes #1373

@brandonroberts brandonroberts merged commit 19a7d06 into 6.1.x Oct 31, 2018
@brandonroberts brandonroberts deleted the pr/6.1.x-fix-router branch October 31, 2018 18:55
@timdeschryver timdeschryver restored the pr/6.1.x-fix-router branch March 27, 2019 21:35
@timdeschryver timdeschryver deleted the pr/6.1.x-fix-router branch March 27, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants