fix(Store): selector with only a projector #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timdeschryver
force-pushed
the
pr/selector-projection
branch
from
24f3f5a to
864fc18
Compare
timdeschryver
commented
Feb 25, 2019
| @@ -143,17 +143,6 @@ describe('Selectors', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it('should not short circuit to the projector fn if there are no selectors and props', () => { | |||
There was a problem hiding this comment.
This test was to verify the fix for #1501.
Since we don't short circuit anymore, this test became obsolete.
BREAKING CHANGE: Selectors with only a projector function aren't valid anymore. This change will make the usage more consistent. BEFORE: ``` const getTodosById = createSelector( (state: TodoAppSchema, id: number) => state.todos.find(p => p.id === id) ); ``` AFTER: ``` const getTodosById = createSelector( (state: TodoAppSchema) => state.todos, (todos: Todo[], id: number) => todos.find(p => p.id === id) ); ```
timdeschryver
force-pushed
the
pr/selector-projection
branch
from
864fc18 to
3447f87
Compare
timdeschryver
changed the title
|
Preview docs changes for 3447f87 at https://previews.ngrx.io/pr1579-3447f87/ |
|
Will you put in another PR that deprecates the old method overload? |
3 tasks
|
Preview docs changes for 26eab59 at https://previews.ngrx.io/pr1579-26eab59/ |
brandonroberts
approved these changes
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #1558
What is the new behavior?
Does this PR introduce a breaking change?
BREAKING CHANGE:
Selectors with only a projector function aren't valid anymore.
This change will make the usage more consistent.
BEFORE:
AFTER: