Skip to content

Conversation

@King-i
Copy link
Contributor

@King-i King-i commented Apr 1, 2019

add runtimeChecks to store root module
add runtimeChecks to tests, removes warning
set ActionReducerMap action type to any inline with rest of example to remove type issue

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #1683

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

add runtimeChecks to store root module
add runtimeChecks to tests, removes warning
set ActionReducerMap action type to any inline with rest of example
to remove type issue
@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 1, 2019

Preview docs changes for 61ed4f5 at https://previews.ngrx.io/pr1686-61ed4f5/

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@brandonroberts brandonroberts merged commit 8dcd696 into ngrx:master Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Example: enable immutability checks

4 participants