Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add explanation and suggested fix for string enforcement of MemoizedSelector type #1772

Merged
merged 6 commits into from
Apr 24, 2019
Merged

docs: add explanation and suggested fix for string enforcement of MemoizedSelector type #1772

merged 6 commits into from
Apr 24, 2019

Conversation

alex-okrushko
Copy link
Member

@alex-okrushko alex-okrushko commented Apr 17, 2019 •
edited
Loading

introduced by PR: #1688

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 17, 2019

Preview docs changes for b344383 at https://previews.ngrx.io/pr1772-b344383/

timdeschryver
timdeschryver reviewed Apr 18, 2019
View reviewed changes
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog is generated and will be overwritten later.
It would be better to add it to the v8 migrations at https://github.com/ngrx/platform/blob/master/projects/ngrx.io/content/guide/migration/v8.md

@alex-okrushko
Copy link
Member Author

alex-okrushko commented Apr 24, 2019 •
edited
Loading

Completely missed the comments 🤦‍♂️

@timdeschryver
Copy link
Member

Seems like you're having some conflicts now, could you rebase @alex-okrushko ? 😁

@alex-okrushko
Copy link
Member Author

@timdeschryver the entire PR is created in Github UI 😁 Merging was fun.

@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 24, 2019

Preview docs changes for 2d23ed2 at https://previews.ngrx.io/pr1772-2d23ed2/

@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 24, 2019

Preview docs changes for fcbc3a7 at https://previews.ngrx.io/pr1772-fcbc3a7/

@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 24, 2019

Preview docs changes for dfa9069 at https://previews.ngrx.io/pr1772-dfa9069/

@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 24, 2019

Preview docs changes for 9351d45 at https://previews.ngrx.io/pr1772-9351d45/

@brandonroberts brandonroberts merged commit 46678f2 into ngrx:master Apr 24, 2019
@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 24, 2019

Preview docs changes for 427f0d1 at https://previews.ngrx.io/pr1772-427f0d1/

@alex-okrushko alex-okrushko deleted the patch-1 branch April 24, 2019 19:48
jordanpowell88 pushed a commit to jordanpowell88/platform that referenced this pull request Nov 16, 2019
@alex-okrushko @jordanpowell88
docs: add explanation and suggested fix for string enforcement of Mem…
7eb62f4 
…oizedSelector type (ngrx#1772)

docs: add Observable type in Effects overview

Closes ngrx#2221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timdeschryver timdeschryver timdeschryver left review comments

@brandonroberts brandonroberts brandonroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alex-okrushko @ngrxbot @timdeschryver @brandonroberts