Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(data): add ng add installation #1799

Merged
merged 3 commits into from
Apr 24, 2019
Merged

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

I think this is the last step in order to close #1554

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Co-Authored-By: timdeschryver <28659384+timdeschryver@users.noreply.github.com>
@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 24, 2019

Preview docs changes for aba0a5c at https://previews.ngrx.io/pr1799-aba0a5c/

@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 24, 2019

Preview docs changes for 06af67e at https://previews.ngrx.io/pr1799-06af67e/

@brandonroberts brandonroberts merged commit 5f23d9d into master Apr 24, 2019
@brandonroberts brandonroberts deleted the pr/data-docs-ng-add branch April 24, 2019 15:12
@johnpapa
Copy link
Contributor

this is awesome!

Where should I make doc PRs - as I see a few tweaks I would like to suggest?

@brandonroberts
Copy link
Member

@johnpapa
Copy link
Contributor

ok - one example idiosyncratic - I think we should use a more widely known word :)

I'll do a run through later.

also - i'd like to update my labs with this, once it's ready to go. What's the timing for making it go live?

@brandonroberts
Copy link
Member

It's ready to test with if you want to try out the latest beta, currently 8.0.0-beta.1. I don't foresee many changes to it other than docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build: add package for ngrx/data
4 participants