Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): add not allowed check to action creator config #2313

Merged
merged 1 commit into from
Jan 11, 2020

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The last commit broke the build, this PR fixes the build.

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@@ -2,6 +2,7 @@ export const compilerOptions = () => ({
moduleResolution: 'node',
target: 'es2015',
baseUrl: '.',
experimentalDecorators: true,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added for debug purposes, because expectSnippet().toSucceed() gives the error on the @Injectable decorators.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment should be in the file itself :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯 I usually just putted the comment in the PR, but it now that I read this comment it's indeed better to add it in the file. Thanks for the tip!

@ngrxbot
Copy link
Collaborator

ngrxbot commented Jan 10, 2020

Preview docs changes for 900c2be at https://previews.ngrx.io/pr2313-900c2be/

@brandonroberts brandonroberts merged commit f6336d5 into master Jan 11, 2020
@brandonroberts brandonroberts deleted the fix/not-allowed-typing branch January 11, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants