Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): add ng-add and ng-update schematics #2598

Merged
merged 3 commits into from
Jul 2, 2020

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #2569

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@timdeschryver timdeschryver force-pushed the pr/component-store-schematics branch from 6f7ed65 to a623e99 Compare June 29, 2020 11:58
@ngrxbot
Copy link
Collaborator

ngrxbot commented Jun 29, 2020

Preview docs changes for c89844a at https://previews.ngrx.io/pr2598-c89844a7/

Copy link
Member

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The angular.json needs to be updated also to build the schematics for component-store.

https://github.com/ngrx/platform/blob/master/angular.json#L252

@timdeschryver
Copy link
Member Author

Thanks @brandonroberts

@brandonroberts brandonroberts merged commit af7b2cc into master Jul 2, 2020
@brandonroberts brandonroberts deleted the pr/component-store-schematics branch July 2, 2020 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component Store: add ng-add supoort
3 participants