Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(resources): ngrx-entity-relationship #2866

Merged
merged 1 commit into from
Jan 12, 2021
Merged

docs(resources): ngrx-entity-relationship #2866

merged 1 commit into from
Jan 12, 2021

Conversation

satanTime
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

no info about the lib https://github.com/satanTime/ngrx-entity-relationship

What is the new behavior?

a section with the info about the lib https://github.com/satanTime/ngrx-entity-relationship

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Hi guys, thanks for NGRX, it's awesome.

There is the known problem about selecting relational data. I always tried to approach it in different ways, and, looks like, finally, I found a solution that might work not only for me, but also for other devs.
Also, when I read this section in the docs, I feel a bit upset, and I hope that one day it will be removed.

Unfortunately, I'm not familiar with standards for being listed in the official docs. Therefore, feel free to point me to any issues I should solve for that.

Thank you in advance and happy coding!

@ngrxbot
Copy link
Collaborator

ngrxbot commented Jan 7, 2021

Preview docs changes for 2ac8eb3 at https://previews.ngrx.io/pr2866-2ac8eb32/

@brandonroberts brandonroberts merged commit 0d8e7fa into ngrx:master Jan 12, 2021
@satanTime
Copy link
Contributor Author

Cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants