Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(example-app): remove store generic #2994

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

timdeschryver
Copy link
Member

@timdeschryver timdeschryver commented Apr 12, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This PR removes the generic interface for Store.
Because of this change, I also had to change the createFeatureSelector method, otherwise it was giving compile erros that state doesn't match the interface.

@brandonroberts brandonroberts merged commit cdb5bd5 into master Apr 12, 2021
@brandonroberts brandonroberts deleted the example-app-store-generic branch April 12, 2021 11:18
@ValentinBossi
Copy link
Contributor

ValentinBossi commented Jul 11, 2021

before this commit with the signature export declare function createFeatureSelector<T, V>(featureName: keyof T): MemoizedSelector<T, V>; it was clear if the state is ok (having all the selected state keys) for selecting when composing two selectors from different createFeatureSelector. now if one feature key is lazy loaded and selected there will be an error, right? @timdeschryver
see also the discussion: #2849 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants