Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(entity): new setMany adapter (#3026) #3029

Merged
merged 2 commits into from
May 26, 2021
Merged

feat(entity): new setMany adapter (#3026) #3029

merged 2 commits into from
May 26, 2021

Conversation

samuelfernandez
Copy link
Contributor

@samuelfernandez samuelfernandez commented May 21, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #3026

What is the new behavior?

New setMany adapter for entities

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented May 21, 2021

Preview docs changes for 4f29830 at https://previews.ngrx.io/pr3029-4f298304/

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good!
We just have to add one more thing to the docs.

@brandonroberts brandonroberts merged commit a02ea9f into ngrx:master May 26, 2021
@samuelfernandez samuelfernandez deleted the set-many-entity-adapter branch May 26, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide setMany adapter for @ngrx/entity
4 participants