Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update packages for npm publishing #3999

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Conversation

brandonroberts
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #

What is the new behavior?

No longer relies on the angular.json to determine which packages are published

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Aug 7, 2023

Deploy Preview for ngrx-io canceled.

Name Link
🔨 Latest commit 5ac90a5
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/64d15e22e8231e00084578c4

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Do we need to merge this collection of publishable packages with the packages collection that are created based on the modules directory?
This to have a single source of truth.

export const packages: PackageDescription[] = fs

@timdeschryver timdeschryver merged commit d2502fb into main Aug 9, 2023
@timdeschryver timdeschryver deleted the build-publish branch August 9, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants