Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router-store): use non-const enum to allow isolatedModules tsconfig option #4554

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

dangrussell
Copy link
Contributor

Using a const enum here triggers "Cannot access ambient const enums when 'isolatedModules' is enabled." error when "isolatedModules" is true in tsconfig.json.

"isolatedModules" is set to true by default in new Angular CLI applications.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Using a const enum here triggers "Cannot access ambient const enums when 'isolatedModules' is enabled." error when "isolatedModules" is `true` in tsconfig.json.

"isolatedModules" is set to `true` by default in new Angular CLI applications.
Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 9572b25
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/6706ab4701064a000860d0e5

@markostanimirovic markostanimirovic changed the title Use a non-const enum to allow isolatedModules tsconfig option fix(router-store): use non-const enum to allow isolatedModules tsconfig option Oct 9, 2024
@markostanimirovic markostanimirovic merged commit f993759 into ngrx:main Oct 9, 2024
11 checks passed
@markostanimirovic
Copy link
Member

Thanks @dangrussell!

@dangrussell dangrussell deleted the patch-1 branch October 10, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants