Rigol dho support enhancement #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed bandwidth calculation for DHO80x.
Added live mode for dho with memory depth = 1k for better performance.
…veforms from different triggers on several channels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Andrew,
As mentioned on Discord, I spent some time testing ngscopclient with my Rigol DHO804 (revamped in a DHO924).
This PR fixes some bugs encountered on large memory depth by activating pagination.
I also created a special "live" mode for memory depth =1k to take advantage of Rigol's "screen" mode.
This allows to double the frame rate at this memory depth.
Finally I tried to fix support for DHO1000/4000 (to be checked with someone owning this models).
Please let me know if it's OK for you to merge.
Oh and to prevent crashes due to the scope returning a null sample_per_rate value in rare cases, I forced it to a dummy value to prevent an Arithmetic exception in WaveformArea::RasterizeAnalogOrDigitalWaveform, but maybe it would be better to handle that in this method.
Best,
Frederic.