fix: add a fixed version of ts-jest #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NachoVazquez
requested review from
LayZeeDK,
santoshyadavdev and
SerkanSipahi
|
Kudos, SonarCloud Quality Gate passed! |
3 tasks
LayZeeDK
added a commit
that referenced
this pull request
Oct 25, 2022
## PR Checklist Please check if your PR fulfills the following requirements: - [x] The commit message follows our guidelines: CONTRIBUTING.md#commit - [x] Tests for the changes have been added (for bug fixes / features) - [x] Docs have been added / updated (for bug fixes / features) ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> ``` [ ] Bugfix [ ] Feature [ ] Code style update (formatting, local variables) [ ] Refactoring (no functional changes, no api changes) [x] Build related changes [x] CI related changes [ ] Documentation content changes [ ] Other... Please describe: ``` ## What is the current behavior? Our CI workflow is broken and we are not publishing a partially Ivy-compiled bundle. <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: N/A ## What is the new behavior? We use Nrwl's Nx Cloud DTE workflow and we can publish a partially Ivy-compiled bundle. ## Does this PR introduce a breaking change? ``` [x] Yes [ ] No ``` <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> - Require Angular 14.0 - Require RxJS 7.4 ## Other information Merging from https://github.com/ngworker/lumberjack-next. Closes #101, closes #84, closes #98
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The
ts-jestversion is an internal dependency of some of our packages but we are using it directly in our project.What is the new behavior?
We are fixing on the
package.jsonthe version ofts-jestthat we are using directlyDoes this PR introduce a breaking change?