Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to async/await everywhere #429

Closed
sinedied opened this issue Jan 14, 2019 · 2 comments
Closed

Migrate to async/await everywhere #429

sinedied opened this issue Jan 14, 2019 · 2 comments
Assignees
@creal73
Labels
feature good first contribution

Comments

@sinedied
Copy link
Member

The next logical step following #399, we should do this everywhere there's promises now 😄
@creal73
Copy link
Collaborator

creal73 commented Apr 11, 2019

Do we want to use async/await only where there is promises ?

What about observable subscriptions like in "home.component.ts" ?

@sinedied
Copy link
Member Author

Only where there is promises, as for observables it's generally more convenient to keep it like that (for composition etc).

@creal73 creal73 self-assigned this Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@creal73 creal73

Labels
feature good first contribution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@creal73 @sinedied