Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to async/await tests and turn off SELENIUM_PROMISE_MANAGER #399

Closed
1 of 3 tasks
captaincaius opened this issue Oct 24, 2018 · 1 comment
Closed
1 of 3 tasks

switch to async/await tests and turn off SELENIUM_PROMISE_MANAGER #399

captaincaius opened this issue Oct 24, 2018 · 1 comment
Labels
feature PR welcome

Comments

@captaincaius
Copy link
Contributor

captaincaius commented Oct 24, 2018 •
edited by sinedied
Loading

I'm submitting a...

  • Bug report
  • Feature request
  • Documentation issue or request

Current behavior

tests are relying on SELENIUM_PROMISE_MANAGER to handle async control flow and keep our tests non-ugly, but it's being deprecated.

Expected behavior

we're on node 8+ with native async/await, so we can turn it off and switch tests to using async/await and keep them pretty ;)

Minimal reproduction of the problem with instructions

N/A
@captaincaius
Copy link
Contributor Author

cool beans. unless someone grabs it before me i'll take this next time i'm in context :)

sinedied added a commit that referenced this issue Jan 14, 2019
@sinedied
Merge pull request #425 from captaincaius/protractor-selenium-promise…
59cbabb 
…-manager-disable

async/await e2e and disable selenium promise manager (closes #399)
@sinedied sinedied mentioned this issue Jan 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature PR welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@captaincaius @sinedied