Extract credentials from authentication service #447
Labels
Comments
sinedied
added a commit
that referenced
this issue
Apr 5, 2019
sinedied
added a commit
that referenced
this issue
Apr 5, 2019
sinedied
added a commit
that referenced
this issue
Apr 5, 2019
sinedied
added a commit
that referenced
this issue
Apr 8, 2019
sinedied
added a commit
that referenced
this issue
Apr 9, 2019
Extract credentials from authentication service (close #447)
sinedied
added a commit
that referenced
this issue
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current authentication services/helpers and its potential link with
HttpServiceis a source of confusion that can lead to unintuitive errors like this #436 and #432I suggest to extract the credentials part in a separate service, so that circular dependencies issues are avoided if anyone adds
HttpServicein theAuthenticationServiceand use the credentials in an interceptor, which is to me a basic use case.The text was updated successfully, but these errors were encountered: