Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add angular-material UI choice #155

Merged
merged 4 commits into from
Oct 17, 2017

Conversation

dvaJi
Copy link
Contributor

@dvaJi dvaJi commented Oct 15, 2017

Ref to #124
I don't know if this new option should be added to ngx-core or extend it. IMO,it's better add it to core.

@sinedied
Copy link
Member

Thanks for the submission, I'll take a look at it ❤️

You are right for the option, I'll add it to the core dependency ASAP.

@sinedied
Copy link
Member

I just published a new @ngx-rocket/core 3.0.0 version with the material prefix support, could you try it to fix the tests?

@sinedied
Copy link
Member

Perfect! Are you ok if I merge this temporarily in a separate branch, so that I can push it a bit further? I would like to make the template responsive using the side menu component, integrate with flex layout and replace font awesome with Material icons.

I have some of these additions WIP here: https://github.com/ngx-rocket/starter-kit/tree/feature/material, it would mostly be a matter of merging it as you did all the template work 👍

@dvaJi
Copy link
Contributor Author

dvaJi commented Oct 17, 2017

Sure! also, I've added a customizable scss but maybe could be good adding options to choose available pre-built themes like:

deeppurple-amber.css
indigo-pink.css
pink-bluegrey.css
purple-green.css

@sinedied sinedied changed the base branch from master to feature/material October 17, 2017 06:55
@sinedied sinedied merged commit 3394746 into ngx-rocket:feature/material Oct 17, 2017
@sinedied
Copy link
Member

That could be an idea, but since you already added customizable theming I think it's more flexible as you can already choose any color combination 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants