Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish to gh-pages #278 - Service Workers relative path #289

Merged
merged 2 commits into from
Apr 7, 2018

Conversation

reflexdemon
Copy link
Contributor

Hi,

Here is a PR for #278. Publish to gh-pages - service worker relative path.

@sinedied
Copy link
Member

Thanks, I'll just do a sanity check with a cordova build and merge it

@reflexdemon
Copy link
Contributor Author

@sinedied

Do you know what could have caused the below?

yarn run v1.5.1
$ ng lint --type-check && stylelint "src/**/*.scss" --syntax scss && htmlhint "src" --config .htmlhintrc
'ng' is not recognized as an internal or external command,
operable program or batch file.
error An unexpected error occurred: "Command failed.

@sinedied
Copy link
Member

@reflexdemon That was an issue fixed with another PR, it should be ok now that I updated the branch.

Before merging I want to make sure this works with cordova builds, but when I tested with Android I had an (unrelated) issue that I need to fix first, so it's taking a bit more time 😕

@reflexdemon
Copy link
Contributor Author

Thanks for response. I was curious to see if I could be of any help here.

@reflexdemon
Copy link
Contributor Author

@sinedied Hey. Loos like the build issue is resolved.

@sinedied
Copy link
Member

sinedied commented Apr 7, 2018

Just tested on mobile, it does not change anything, so it's good to merge :)

@sinedied sinedied merged commit c6993e0 into ngx-rocket:master Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants