-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for analytics with Angulartics2. #294
Conversation
…to Google Analytics for now.
Nice, UT are working now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a missing class for the bootstrap button 😉
<% if (props.angulartics) { -%> | ||
<p> | ||
<button | ||
class="btn" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's missing a button style, like btn-primary
(see https://getbootstrap.com/docs/4.0/components/buttons/)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Includes full support and examples for Google Analytics provider (for other providers, only the npm package and module import are done).
Documentation is also included.
Close #136