Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for analytics with Angulartics2. #294

Merged
merged 9 commits into from
Mar 30, 2018
Merged

Conversation

bursauxa
Copy link
Contributor

@bursauxa bursauxa commented Mar 22, 2018

Includes full support and examples for Google Analytics provider (for other providers, only the npm package and module import are done).

Documentation is also included.

Close #136

@bursauxa bursauxa mentioned this pull request Mar 27, 2018
4 tasks
@sinedied
Copy link
Member

Nice, UT are working now 👍

Copy link
Member

@sinedied sinedied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a missing class for the bootstrap button 😉

<% if (props.angulartics) { -%>
<p>
<button
class="btn"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's missing a button style, like btn-primary (see https://getbootstrap.com/docs/4.0/components/buttons/)

Copy link
Member

@sinedied sinedied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sinedied sinedied merged commit 5646332 into master Mar 30, 2018
@sinedied sinedied deleted the feature/analytics branch March 30, 2018 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants