Inital support of electron target #333
Conversation
| @@ -0,0 +1,60 @@ | |||
| const electron = require('electron') | |||
There was a problem hiding this comment.
Could it be possible to use TS also here? (for a later version, JS is fine for a first release!)
Seems that can be done, as seen with https://github.com/maximegris/angular-electron, but it does not seems pretty :/
| <% if (props.target.includes('electron')) { -%> | ||
| "electron:run": "electron .", | ||
| "electron:build": "npm run env -s && ng build --prod --base-href ./", | ||
| "electron:package:win" : "electron-packager . --overwrite --platform=win32 --arch=ia32 --out=out --icon=src/assets/icon.ico", |
There was a problem hiding this comment.
use a dist-electron folder? (+ add it to .gitignore)
Then it would be nice to add win64/linux/mac commands, along with a electron:package to run them all at once.
Also, with this you should add a question like with cordova to choose target platforms ie: win32, win64, linux, osx then the PR would be complete :)
| @@ -53,6 +61,9 @@ | |||
| "cordova-plugin-statusbar": "^2.4.1", | |||
| "cordova-plugin-whitelist": "^1.3.3", | |||
| <% } -%> | |||
| <% if (props.target.includes('electron')) { -%> | |||
| "electron": "^1.8.2", | |||
There was a problem hiding this comment.
Don't forget to upgrade to latest 2.x version before merging!
…upgrade of electron version
| "electron-winstaller": "^2.2.0", | ||
| "electron": "^2.0.6", | ||
| "electron-packager": "^12.1.0", | ||
| "electron-winstaller": "^2.6.4", |
There was a problem hiding this comment.
Is "electron-winstaller": "^2.6.4" actually used? Or is it needed by electron packager maybe?
|
@YoannHub Besides the conflict, is it still WIP or can it be merged? IMHO, it's only missing the target platform choice (ie win / linux / mac) but that could be done in a separate PR 🙂 |
|
@sinedied I think we can merge it as is, it's been tested on Windows and Mac target, I have not been able to test on the Linux version |
sinedied
changed the title
As of this implementation only windows target has been tested.
Choose web app and electron when scaffolding a new application.
npm run electron:build: build app for electron
npm run electron:run: run app in electron
npm run electron:package:win: build windows executable app