Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added prettier support (closes #303) and init git repo by default #380

Merged
merged 4 commits into from
Sep 13, 2018

Conversation

sinedied
Copy link
Member

  • Added prettier generation question (disabled by default)
  • Added a git option to init git repository after project generation (enabled by default)
  • Added prettier pre-commit hook when git option is enabled
  • Added prettier configs to avoid conflicts with tslint/stylelint
  • If prettier is enabled, code is formatted as a npm postinstall hook
  • Updated docs

- Added prettier generation question (disabled by default)
- Added a `git` option to init git repository after project generation (enabled by default)
- Added prettier pre-commit hook when git option is enabled
- Added prettier configs to avoid conflicts with tslint/stylelint
- If prettier is enabled, code is formatted as a npm postinstall hook
- Updated docs
Copy link
Contributor

@bursauxa bursauxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I assume one of the changes in package.json caused the CI failure? Although I could not pinpoint it by only looking at the source.

and enforced via the `test:ci` script.
<% if (options.git) { -%>

A pre-commit git hook have been configured on this project to automatically format staged files, using
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has been configured

@sinedied
Copy link
Member Author

For the CI there seems to be an issue specific to appveyor regarding the chrome download, it's not specific to this PR 😞 Hopefully it will be resolved soon...

Thanks for catching the spelling mistake, I'll fix that 😉

@sinedied sinedied merged commit 7572ebb into master Sep 13, 2018
@sinedied sinedied deleted the feature/prettier branch September 13, 2018 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants