Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synced up polyfills with latest angular CLI #391

Merged

Conversation

captaincaius
Copy link
Contributor

minor changes to polyfills comments...

NOTE: I didn't do this one: angular/angular-cli@d3fa9a6#diff-7ed40e1057374060b6223a05a7046411

Is it safe for us? I didn't see any explanation/issue/etc other than the commit message, so I wanted to be conservative and ask first.

@captaincaius
Copy link
Contributor Author

looks like the deprecated ionic keyboard is suddenly making everything red. Seems this failure is on master too. Should we backport the change in the ionic4 branch to master?

@captaincaius
Copy link
Contributor Author

As for this branch, syncing this after merging the to-ionic4 PR into 6.x should turn this green...

For master, I submitted this PR #393 :)

@sinedied
Copy link
Member

Thanks, I missed this in the v6 update 😛

NOTE: I didn't do this one: angular/angular-cli@d3fa9a6#diff-7ed40e1057374060b6223a05a7046411

Is it safe for us? I didn't see any explanation/issue/etc other than the commit message, so I wanted to > be conservative and ask first.

As of now, only the unit tests runs in JIT mode due to CLI limitations, so I would say if they removed it and if our CI running the tests is OK with that, it should be safe to include 😄

@captaincaius
Copy link
Contributor Author

Cool beans. Good point - the comment said evergeen browsers need it, so I guess we can trust our tests to tell us :)

I see you updated this one. I'll push a different PR with it removed so we know which one we can merge :)

Oh, do you want it on master too?

@captaincaius
Copy link
Contributor Author

yup - #394 failed, so this one wins. :)

@sinedied sinedied merged commit f21687f into ngx-rocket:release/6.0.x Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants