Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated generator code base to xo + prettier and async/await #401

Merged
merged 3 commits into from
Oct 26, 2018
Merged

Migrated generator code base to xo + prettier and async/await #401

merged 3 commits into from
Oct 26, 2018
+1,162 −185

Conversation

sinedied
Copy link
Member

Also fixed readme

@sinedied
Migrated generator code base to xo + prettier and async/await

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
5a7c357 
Also fixed readme
@bursauxa
Copy link
Contributor

Regarding the prompts changed from 'What\'s your...' to "What's your", I think we should avoid contractions altogether. A more formal 'What is your...' would be appropriate in this context. Console logs are fine though.

@sinedied sinedied merged commit 26b5ac3 into master Oct 26, 2018
@sinedied sinedied deleted the feature/xo branch October 26, 2018 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sinedied @bursauxa