Skip to content

Commit

Permalink
Merge pull request #34 from ngxpert/feat/ng-19
Browse files Browse the repository at this point in the history
Feat/ng 19
  • Loading branch information
shhdharmen authored Dec 10, 2024
2 parents 44f6454 + 62cebfc commit a971bf7
Show file tree
Hide file tree
Showing 22 changed files with 6,053 additions and 4,477 deletions.
24 changes: 15 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,15 @@ https://github.com/ngxpert/hot-toast/assets/6831283/ae718568-d5ea-47bf-a41d-6aab
3.x
</td>
<td>
>= 18
>= 18 < 19
</td>
</tr>
<tr>
<td>
4.x
</td>
<td>
>= 19
</td>
</tr>
</tbody>
Expand Down Expand Up @@ -81,14 +89,6 @@ yarn add @ngneat/overview@6.1.1 @ngxpert/hot-toast
<details>
<summary>For older versions</summary>

You can install it through **Angular CLI**:

```bash
ng add @ngneat/hot-toast
```

or with **npm**:

```bash
# For Angular version >= 9.1.13 < 13
npm install @ngneat/overview@2.0.2 @ngneat/hot-toast@3
Expand All @@ -101,6 +101,12 @@ npm install @ngneat/overview@3.0.0 @ngneat/hot-toast@5

# For Angular version >= 16 <17
npm install @ngneat/overview@5.1.1 @ngneat/hot-toast@6

# For Angular version >= 17 <18
npm install @ngneat/overview@6.0.0 @ngxpert/hot-toast@2

# For Angular version >= 18 <19
npm install @ngneat/overview@6.1.1 @ngxpert/hot-toast@3
```

</details>
Expand Down
8 changes: 1 addition & 7 deletions cypress.config.ts
Original file line number Diff line number Diff line change
@@ -1,14 +1,8 @@
import { defineConfig } from 'cypress';

export default defineConfig({
video: false,
e2e: {
// We've imported your old cypress plugins here.
// You may want to clean this up later by importing these.
setupNodeEvents(on, config) {
return require('./cypress/plugins/index.js')(on, config);
},
baseUrl: 'http://localhost:4200',
excludeSpecPattern: '**/examples/*.spec.js',
testIsolation: false,
},
});
26 changes: 15 additions & 11 deletions cypress/e2e/toast_grouping.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,13 @@ describe('Toast Grouping', () => {

// Check parent toast appears with retry and longer timeout
cy.get('.hot-toast-bar-base', { timeout: 10000 }).should('be.visible');
cy.get('.hot-toast-bar-base').within(() => {
cy.contains('New Activities', { timeout: 5000 }).should('be.visible');
cy.contains('5 New Activities', { timeout: 5000 }).should('be.visible');
cy.contains("What's happening around you!", { timeout: 5000 }).should('be.visible');
});
cy.get('.hot-toast-bar-base')
.first()
.within(() => {
cy.contains('New Activities', { timeout: 5000 }).should('be.visible');
cy.contains('5 New Activities', { timeout: 5000 }).should('be.visible');
cy.contains("What's happening around you!", { timeout: 5000 }).should('be.visible');
});

// Check expand/collapse functionality with wait
cy.get('.hot-toast-group-btn').should('be.visible').click();
Expand Down Expand Up @@ -71,12 +73,14 @@ describe('Toast Grouping', () => {

// Check parent toast appears with retry and longer timeout
cy.get('.hot-toast-bar-base', { timeout: 10000 }).should('be.visible');
cy.get('.hot-toast-bar-base').within(() => {
// Wait for all notifications to be added and visible
cy.contains(/[0-5] New Activities/, { timeout: 10000 }).should('be.visible');
cy.contains("What's happening around you!", { timeout: 5000 }).should('be.visible');
cy.get('.hot-toast-close-btn').should('be.visible');
});
cy.get('.hot-toast-bar-base')
.first()
.within(() => {
// Wait for all notifications to be added and visible
cy.contains(/[0-5] New Activities/, { timeout: 10000 }).should('be.visible');
cy.contains("What's happening around you!", { timeout: 5000 }).should('be.visible');
cy.get('.hot-toast-close-btn').should('be.visible');
});

// Check expand/collapse functionality with wait
cy.get('.hot-toast-group-btn').should('be.visible').click();
Expand Down
5 changes: 0 additions & 5 deletions cypress/fixtures/example.json

This file was deleted.

21 changes: 0 additions & 21 deletions cypress/plugins/index.js

This file was deleted.

Loading

0 comments on commit a971bf7

Please sign in to comment.