Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Grouping - Allows users to group toasts into 1 toast #5

Merged
merged 10 commits into from
Apr 17, 2024
Merged

Conversation

shhdharmen
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

As of now, there is no feature to achieve grouping of toasts.

What is the new behavior?

New behaviour will allow user to group multiple toasts into 1 toast. See attached video for reference:

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

The <div> surrounding <ng-container> is removed from .hot-toast-message to better and easy structure of layout. User may need to check their templates after updating to v2.

2024-04-16.19-11-24.mp4

shhdharmen and others added 10 commits April 15, 2024 00:50
to keep structure simple, removed div around ng-container in .hot-toast-message

BREAKING CHANGE: a div around ng-container in .hot-toast-message has been removed. User will need to
take care of this in their ng-template
# [2.0.0-beta.1](v1.0.0...v2.0.0-beta.1) (2024-04-17)

### Bug Fixes

* handle expanded in doCheck ([58a188a](58a188a))
* make options optional in show function ([8ecbbc2](8ecbbc2))

### Features

* add grouping feature ([c342de6](c342de6))
* post grouping ([bc32842](bc32842))
* remove first child div from .hot-toast-message ([8b7b09f](8b7b09f))

### BREAKING CHANGES

* a div around ng-container in .hot-toast-message has been removed. User will need to
take care of this in their ng-template
@shhdharmen shhdharmen self-assigned this Apr 17, 2024
@shhdharmen shhdharmen merged commit f12146b into main Apr 17, 2024
2 checks passed
Copy link

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@shhdharmen shhdharmen deleted the beta branch April 17, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants