Skip to content

Commit

Permalink
feat(store): expose ActionContext and ActionStatus
Browse files Browse the repository at this point in the history
  • Loading branch information
arturovt committed Jun 22, 2021
1 parent e6a0b2b commit 0b61412
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 5 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
$ npm install @ngxs/store@dev
```

- Feature: Expose `ActionContext` and `ActionStatus` [#1766](https://github.com/ngxs/store/pull/1766)
- Fix: Do not re-use the global `Store` instance between different apps [#1740](https://github.com/ngxs/store/pull/1740)
- Fix: Do not run `Promise.then` within synchronous tests when decorating factory [#1753](https://github.com/ngxs/store/pull/1753)
- Fix: Devtools Plugin - Do not connect to devtools when the plugin is disabled [#1761](https://github.com/ngxs/store/pull/1761)
Expand Down
4 changes: 1 addition & 3 deletions packages/store/src/actions-stream.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,7 @@ export class InternalActions extends OrderedSubject<ActionContext> {}
* You can listen to this in services to react without stores.
*/
@Injectable()
export class Actions extends Observable<any> {
// This has to be `Observable<ActionContext>` in the v4. Because `InternalActions`
// is a `Subject<ActionContext>`. Leave it as `any` to avoid breaking changes
export class Actions extends Observable<ActionContext> {
constructor(
internalActions$: InternalActions,
internalExecutionStrategy: InternalNgxsExecutionStrategy
Expand Down
2 changes: 1 addition & 1 deletion packages/store/src/public_api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ export { Store } from './store';
export { State } from './decorators/state';
export { Select } from './decorators/select/select';
export { SelectorOptions } from './decorators/selector-options';
export { Actions } from './actions-stream';
export { Actions, ActionContext, ActionStatus } from './actions-stream';

// TODO: v4 - We need to come up with an alternative api to exposing this metadata
// because it is currently used by the following (after a github search):
Expand Down
2 changes: 1 addition & 1 deletion packages/websocket-plugin/src/websocket-handler.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Injectable, Inject, OnDestroy } from '@angular/core';
import { Actions, Store, getValue, ofActionDispatched } from '@ngxs/store';
import { Subscription } from 'rxjs';
import { fromEvent, Subscription } from 'rxjs';

import { WebSocketSubject, WebSocketSubjectConfig } from 'rxjs/webSocket';

Expand Down

0 comments on commit 0b61412

Please sign in to comment.