-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(operators): improve publicly exposed types #1956
Conversation
9ab4386
to
c592331
Compare
BundleMonFiles updated (1)
Unchanged files (2)
Total files change +13B +0.01% Groups updated (1)
Unchanged groups (2)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (NGXS Plugins)Unchanged files (14)
No change in files bundle size Unchanged groups (3)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (Integration Projects)Unchanged files (3)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
Code Climate has analyzed commit c592331 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 97.0% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love comments
## PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #1715
What is the new behavior?
construct their own State Operators.
AsReadOnly
type so that the typescript error messaging is not referring to an internal type.PatchSpec
type with a barred O notation so that it can be used externally, but it used with caution in case the internal type representation changes.Does this PR introduce a breaking change?
Other information