feat(devtools-plugin): add trace options to `NgxsDevtoolsOptions` #1968

Dyqmin · 2023-02-04T02:02:04Z

Allow to pass trace and traceLimit redux-devtools options, to enable actions calls tracing

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/ngxs/store/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

No support for actions calls tracing

Issue Number: N/A

What is the new behavior?

The change allows adding new trace and traceLimit options to the devtools module.

NgxsReduxDevtoolsPluginModule.forRoot({ disabled: env.production, trace: true, traceLimit: 70 })

New options were implemented to follow the official redux-devtools API

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Allow to pass `trace` and `traceLimit` redux-devtools options, to enable tracing actions calls

codeclimate · 2023-02-06T14:16:31Z

Code Climate has analyzed commit c599da0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 96.9% (0.0% change).

View more on Code Climate.

bundlemon · 2023-02-06T15:54:24Z

BundleMon

Unchanged files (3)

Status	Path	Size	Limits
✅	fesm2015/ngxs-store.js	89.12KB	125KB / +0.5%
✅	fesm2015/ngxs-store-operators.js	6.23KB	15KB / +0.5%
✅	fesm2015/ngxs-store-internals.js	4.22KB	20KB / +0.5%

No change in files bundle size

Unchanged groups (3)

Status	Path	Size	Limits
✅	@ngxs/store(esm2015)[gzip] _{./esm2015/*/.js}	167.06KB	+1%
✅	@ngxs/store(umd)[gzip] _{./bundles/*.umd.js}	35.34KB	+1%
✅	@ngxs/store(fesm2015)[gzip] _{./fesm2015/*.js}	24.04KB	+1%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

bundlemon · 2023-02-06T15:54:26Z

BundleMon (NGXS Plugins)

Unchanged files (14)

Status	Path	Size	Limits
✅	Plugins(umd)[gzip] _{storage-plugin/bundles/ngxs-storage-plugin.um d.js}	7.96KB	+1%
✅	Plugins(umd)[gzip] _{router-plugin/bundles/ngxs-router-plugin.umd. js}	7.41KB	+1%
✅	Plugins(umd)[gzip] _{websocket-plugin/bundles/ngxs-websocket-plugi n.umd.js}	6.92KB	+1%
✅	Plugins(umd)[gzip] _{hmr-plugin/bundles/ngxs-hmr-plugin.umd.js}	6.89KB	+1%
✅	Plugins(fesm2015)[gzip] _{storage-plugin/fesm2015/ngxs-storage-plugin.j s}	3.64KB	+1%
✅	Plugins(umd)[gzip] _{form-plugin/bundles/ngxs-form-plugin.umd.js}	3.41KB	+1%
✅	Plugins(fesm2015)[gzip] _{router-plugin/fesm2015/ngxs-router-plugin.js}	3.09KB	+1%
✅	Plugins(umd)[gzip] _{devtools-plugin/bundles/ngxs-devtools-plugin. umd.js}	2.75KB	+1%
✅	Plugins(fesm2015)[gzip] _{form-plugin/fesm2015/ngxs-form-plugin.js}	2.65KB	+1%
✅	Plugins(fesm2015)[gzip] _{hmr-plugin/fesm2015/ngxs-hmr-plugin.js}	2.65KB	+1%
✅	Plugins(fesm2015)[gzip] _{websocket-plugin/fesm2015/ngxs-websocket-plug in.js}	2.59KB	+1%
✅	Plugins(umd)[gzip] _{logger-plugin/bundles/ngxs-logger-plugin.umd. js}	2.53KB	+1%
✅	Plugins(fesm2015)[gzip] _{devtools-plugin/fesm2015/ngxs-devtools-plugin .js}	2.17KB	+1%
✅	Plugins(fesm2015)[gzip] _{logger-plugin/fesm2015/ngxs-logger-plugin.js}	2.01KB	+1%

No change in files bundle size

Groups updated (1)

Status	Path	Size	Limits
✅	All Plugins(esm2015)[gzip] _{./-plugin/esm2015/**/.js}	108.59KB (+144B +0.13%)	+1%

Unchanged groups (2)

Status	Path	Size	Limits
✅	All Plugins(umd)[gzip] _{./-plugin/bundles/.umd.js}	37.88KB	+1%
✅	All Plugins(fesm2015)[gzip] _{./-plugin/fesm2015/.js}	18.8KB	+1%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

bundlemon · 2023-02-06T15:54:29Z

BundleMon (Integration Projects)

Unchanged files (3)

Status	Path	Size	Limits
✅	Main bundles(Gzip) _{hello-world-ng13-ivy/dist-integration/main.(h ash).js}	69.79KB	+1%
✅	Main bundles(Gzip) _{hello-world-ng12-ivy/dist-integration/main.(h ash).js}	67.95KB	+1%
✅	Main bundles(Gzip) _{hello-world-ng14-ivy/dist-integration/main.(h ash).js}	65.46KB	+1%

Total files change -2B 0%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@ngxs/form-plugin](https://github.com/ngxs/store) | dependencies | minor | [`3.7.6` -> `3.8.0`](https://renovatebot.com/diffs/npm/@ngxs%2fform-plugin/3.7.6/3.8.0) | | [@ngxs/storage-plugin](https://github.com/ngxs/store) | dependencies | minor | [`3.7.6` -> `3.8.0`](https://renovatebot.com/diffs/npm/@ngxs%2fstorage-plugin/3.7.6/3.8.0) | | [@ngxs/store](https://github.com/ngxs/store) | dependencies | minor | [`3.7.6` -> `3.8.0`](https://renovatebot.com/diffs/npm/@ngxs%2fstore/3.7.6/3.8.0) | --- ### Release Notes <details> <summary>ngxs/store</summary> ### [`v3.8.0`](https://github.com/ngxs/store/blob/HEAD/CHANGELOG.md#380-2023-03-29) [Compare Source](ngxs/store@v3.7.6...v3.8.0) - Feature: Build packages in Ivy format [#1945](ngxs/store#1945) - Feature: Add advanced selector utilities [#1824](ngxs/store#1824) - Feature: Expose `ActionContext` and `ActionStatus` [#1766](ngxs/store#1766) - Feature: `ofAction*` methods should have strong types [#1808](ngxs/store#1808) - Feature: Improve contextual type inference for state operators [#1806](ngxs/store#1806) [#1947](ngxs/store#1947) - Feature: Enable warning on unhandled actions [#1870](ngxs/store#1870) [#1951](ngxs/store#1951) - Feature: Router Plugin - Provide more actions and navigation timing option [#1932](ngxs/store#1932) - Feature: Storage Plugin - Allow providing namespace for keys [#1841](ngxs/store#1841) - Feature: Storage Plugin - Enable providing storage engine individually [#1935](ngxs/store#1935) - Feature: Devtools Plugin - Add new options to the `NgxsDevtoolsOptions` interface [#1879](ngxs/store#1879) - Feature: Devtools Plugin - Add trace options to `NgxsDevtoolsOptions` [#1968](ngxs/store#1968) - Feature: Form Plugin - Allow `ngxsFormDebounce` to be string [#1972](ngxs/store#1972) - Performance: Tree-shake patch errors [#1955](ngxs/store#1955) - Fix: Get descriptor explicitly when it's considered as a class property [#1961](ngxs/store#1961) - Fix: Avoid delayed updates from state stream [#1981](ngxs/store#1981) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1837 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

Dyqmin requested review from markwhitfeld, arturovt, kuncevic, Carniatto, poloagustin, joaqcid and splincode as code owners February 4, 2023 02:02

arturovt approved these changes Feb 6, 2023

View reviewed changes

feat(devtools-plugin): add trace options to NgxsDevtoolsOptions

c599da0

Allow to pass `trace` and `traceLimit` redux-devtools options, to enable tracing actions calls

Dyqmin force-pushed the feat/dev-tools-trace-options branch from b514cd2 to c599da0 Compare February 6, 2023 14:12

arturovt merged commit c0b40ba into ngxs:master Feb 6, 2023

markwhitfeld added this to the v3.8.0 milestone Mar 29, 2023

abdulrahman305 mentioned this pull request Jul 3, 2024

[Snyk] Upgrade: , , , , abdulrahman305/auptimizer#4

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(devtools-plugin): add trace options to `NgxsDevtoolsOptions` #1968

feat(devtools-plugin): add trace options to `NgxsDevtoolsOptions` #1968

Dyqmin commented Feb 4, 2023 •

edited

Loading

codeclimate bot commented Feb 6, 2023

bundlemon bot commented Feb 6, 2023

bundlemon bot commented Feb 6, 2023

bundlemon bot commented Feb 6, 2023

feat(devtools-plugin): add trace options to NgxsDevtoolsOptions #1968

feat(devtools-plugin): add trace options to NgxsDevtoolsOptions #1968

Conversation

Dyqmin commented Feb 4, 2023 • edited Loading

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

codeclimate bot commented Feb 6, 2023

bundlemon bot commented Feb 6, 2023

BundleMon

bundlemon bot commented Feb 6, 2023

BundleMon (NGXS Plugins)

bundlemon bot commented Feb 6, 2023

BundleMon (Integration Projects)

feat(devtools-plugin): add trace options to `NgxsDevtoolsOptions` #1968

feat(devtools-plugin): add trace options to `NgxsDevtoolsOptions` #1968

Dyqmin commented Feb 4, 2023 •

edited

Loading