fix(store): expose keys which are used to store metadata privately #2054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturovt
requested review from
markwhitfeld,
kuncevic,
Carniatto,
poloagustin,
joaqcid and
splincode
as code owners
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0a18a52. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
BundleMon (Integration Projects)Files updated (1)
Total files change -12B -0.02% Final result: ✅ View report in BundleMon website ➡️ |
arturovt
force-pushed
the
fix/expose-meta-internals
branch
from
60e35c6
to
917b8d6
Compare
This commit relocates keys used for storing metadata and options on state classes to the internals package. It can now be exposed to plugin authors who need to retrieve metadata from state classes and prefer a stable key.
arturovt
force-pushed
the
fix/expose-meta-internals
branch
from
917b8d6
to
0a18a52
Compare
|
Code Climate has analyzed commit 0a18a52 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.5% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit relocates keys used for storing metadata and options on state classes to the internals package. It can now be exposed to plugin authors who need to retrieve metadata from state classes and prefer a stable key.