fix(store): patch operator must handle existing nulls #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed patch operator not fail when the existing value is null by using a null save access to the key of the object fixes ngxs#2063
TheKingDave
requested review from
markwhitfeld,
arturovt,
kuncevic,
Carniatto,
poloagustin,
joaqcid and
splincode
as code owners
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 5db904a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
markwhitfeld
requested changes
Oct 20, 2023
Co-authored-by: Mark Whitfeld <markwhitfeld@users.noreply.github.com>
BundleMon (Integration Projects)Unchanged files (1)
Total files change -3B 0% Final result: ✅ View report in BundleMon website ➡️ |
|
Code Climate has analyzed commit 5db904a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.5%. View more on Code Climate. |
markwhitfeld
approved these changes
Nov 10, 2023
markwhitfeld
changed the title
markwhitfeld
pushed a commit
that referenced
this pull request
Nov 30, 2023
* fix(store): made patch operator handle existing null nicely Changed patch operator not fail when the existing value is null by using a null save access to the key of the object fixes #2063 * Apply suggestions from code review Co-authored-by: Mark Whitfeld <markwhitfeld@users.noreply.github.com> --------- Co-authored-by: Mark Whitfeld <markwhitfeld@users.noreply.github.com> (cherry picked from commit bd067dd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed patch operator not fail when the existing value is null by using a null save access to the key of the object
fixes #2063
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When the existing value of the patch operator is null/undefined it causes a key access error
Issue Number: #2063
What is the new behavior?
Does not throw an error if existin is null/undefined
Does this PR introduce a breaking change?
Other information