Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: integration app serve targets #2084

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

Dyqmin
Copy link
Contributor

@Dyqmin Dyqmin commented Nov 28, 2023

changes the old build-app target to build

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link

nx-cloud bot commented Nov 28, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c610685. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

Copy link

bundlemon bot commented Nov 28, 2023

BundleMon (Integration Projects)

Unchanged files (1)
Status Path Size Limits
Main bundles(Gzip)
hello-world-ng15/dist-integration/main.(hash)
.js
63.35KB +1%

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

changes the old `build-app` target to `build`
@Dyqmin Dyqmin changed the title fix: integration app serve targets refactor: integration app serve targets Nov 29, 2023
Copy link

codeclimate bot commented Nov 29, 2023

Code Climate has analyzed commit c610685 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 94.9% (0.0% change).

View more on Code Climate.

@arturovt arturovt merged commit b5960ba into ngxs:master Nov 29, 2023
13 checks passed
@Dyqmin Dyqmin deleted the fix/integration-app-targets branch November 30, 2023 11:53
@markwhitfeld markwhitfeld added this to the v.18.0.0 milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants