Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): add selectSignal #2097

Merged
merged 5 commits into from
Mar 10, 2024
Merged

feat(store): add selectSignal #2097

merged 5 commits into from
Mar 10, 2024

Conversation

arturovt
Copy link
Member

@arturovt arturovt commented Feb 5, 2024

No description provided.

Copy link

nx-cloud bot commented Feb 5, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fcc777e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

Copy link
Member

@markwhitfeld markwhitfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @artur. Great start to this!!!!
The biggest point here is about the new API only supporting typed selectors, and not exposing the options for the computed).
The other things that would still be needed in this PR are:

  • Update the integration app to have both signal and observable variants that pass the integration tests
  • Add unit tests for the new selectSignal function. We can probably copy-paste all of the type-safe tests for store.select as a baseline for this.

packages/store/src/store.ts Outdated Show resolved Hide resolved
packages/store/src/store.ts Outdated Show resolved Hide resolved
integration/app/app.component.ts Outdated Show resolved Hide resolved
Copy link
Member

@markwhitfeld markwhitfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Do you know what is going on with the types test?

@arturovt
Copy link
Member Author

Looking good. Do you know what is going on with the types test?

@angular/core/rxjs-interop is using some latest TS features not supported by the TS version installed in store/types. I can't upgrade that TS version because dtslint uses tslint which is tied to lower TS version.

Copy link

bundlemon bot commented Feb 18, 2024

BundleMon (Integration Projects)

Files updated (2)
Status Path Size Limits
Main bundles(Gzip)
hello-world-ng16/dist-integration/main.(hash)
.js
66.87KB (+981B +1.45%) +1%
Main bundles(Gzip)
hello-world-ng17/dist-integration/main.(hash)
.js
68.36KB (+974B +1.41%) +1%

Total files change +1.91KB +1.43%

Final result: ❌

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@arturovt arturovt force-pushed the feat/select-signal branch 2 times, most recently from 345944c to eabcb9a Compare February 18, 2024 12:41
@arturovt
Copy link
Member Author

@markwhitfeld I switched from dtslint to ESLint that supports linting files with $Expect comments.

Copy link

codeclimate bot commented Mar 10, 2024

Code Climate has analyzed commit fcc777e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.5% (0.0% change).

View more on Code Climate.

@arturovt arturovt merged commit dbed85b into master Mar 10, 2024
13 checks passed
@arturovt arturovt deleted the feat/select-signal branch March 10, 2024 18:59
@markwhitfeld markwhitfeld added this to the v.18.0.0 milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants