-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(store): add selectSignal
#2097
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit fcc777e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
829232a
to
9dbf3fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @artur. Great start to this!!!!
The biggest point here is about the new API only supporting typed selectors, and not exposing the options
for the computed).
The other things that would still be needed in this PR are:
- Update the integration app to have both signal and observable variants that pass the integration tests
- Add unit tests for the new
selectSignal
function. We can probably copy-paste all of the type-safe tests forstore.select
as a baseline for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Do you know what is going on with the types test?
|
BundleMon (Integration Projects)Files updated (2)
Total files change +1.91KB +1.43% Final result: ❌ View report in BundleMon website ➡️ |
345944c
to
eabcb9a
Compare
@markwhitfeld I switched from dtslint to ESLint that supports linting files with |
eabcb9a
to
748bfad
Compare
Code Climate has analyzed commit fcc777e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.5% (0.0% change). View more on Code Climate. |
No description provided.