fix(store): enable throwing errors from selectors by default #2111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4fb898e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
BundleMon (Integration Projects)Files updated (2)
Total files change +216B +0.16% Final result: ✅ View report in BundleMon website ➡️ |
This commit updates the `suppressErrors` configuration property to default to falsy. Consequently, if the selector function throws a type error (such as when accessing a property unsafely), the error will now be thrown. `selectSnapshot` will throw synchronously, while errors from `select` will be thrown asynchronously because the RxJS error reporter operates within a `setTimeout`. We log errors in development mode to assist developers in identifying selectors that have thrown. This change is breaking and is part of the v4 release preparation.
arturovt
force-pushed
the
fix/supress-errors
branch
from
8cd45a2
to
4fb898e
Compare
18 tasks
|
Code Climate has analyzed commit 4fb898e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.4% (0.0% change). View more on Code Climate. |
arturovt
requested review from
markwhitfeld,
kuncevic,
Carniatto,
poloagustin,
joaqcid and
splincode
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the
suppressErrorsconfiguration property to default to falsy.Consequently, if the selector function throws a type error (such as when accessing a
property unsafely), the error will now be thrown.
selectSnapshotwill throw synchronously, while errors fromselectwill be thrownasynchronously because the RxJS error reporter operates within a
setTimeout.We log errors in development mode to assist developers in identifying selectors that have thrown.
This change is breaking and is part of the v4 release preparation.