fix(store): select,selectOnce,selectSnapshot should only accept typed selector
#2116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit fc8d954. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
…ed selector This commit modifies the signatures of `select`, `selectOnce`, and `selectSnapshot` to exclusively accept typed selectors. They should not permit acceptance of anything lacking type information, such as state classes (`select(MyState)`), strings, or anonymous functions. Only state tokens and selectors are now allowed. This adjustment also impacts the router plugin, as it previously used `RouterState` for selecting snapshots, which is no longer allowed. Consequently, we introduced `ROUTER_STATE_TOKEN` as the replacement for selections involving `RouterState`.
arturovt
force-pushed
the
fix/typed-selector
branch
from
e3c5001
to
fc8d954
Compare
|
Code Climate has analyzed commit fc8d954 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.4% (0.0% change). View more on Code Climate. |
BundleMon (Integration Projects)Files updated (2)
Total files change +26B +0.02% Final result: ✅ View report in BundleMon website ➡️ |
arturovt
requested review from
markwhitfeld,
kuncevic,
Carniatto,
poloagustin,
joaqcid and
splincode
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies the signatures of
select,selectOnce, andselectSnapshotto exclusively accept typed selectors. They should not permit acceptance of anything lacking type information, such as state classes (select(MyState)), strings, or anonymous functions. Only state tokens and selectors are now allowed.This adjustment also impacts the router plugin, as it previously used
RouterStatefor selecting snapshots, which is no longer allowed. Consequently, we introducedROUTER_STATE_TOKENas the replacement for selections involvingRouterState.