-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(store): add dispatch
utility
#2143
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1c7a57e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
BundleMon (Integration Projects)Unchanged files (2)
Total files change -9B -0.01% Final result: ✅ View report in BundleMon website ➡️ |
I think we should include the |
I thought similarly, believing it should be a part of the signals package, mainly because those utilities are quite similar. |
Although it makes sense to have |
Good point @profanis. What would you propose as the ideal split of APIs to packages here? |
you could move
|
I like that! |
I see these utilities as generally useful, and not specific to ngrx signal store though. |
What is your recommendation? |
Merged. Can revert if we agree to do this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy for all of this to move to the @ngxs/store
package.
I think it makes more sense to all be core.
No description provided.