Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schematics): remove local ng utils for schematics #2184

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

dmitry-stepanenko
Copy link
Contributor

closes #2183

Copy link

nx-cloud bot commented Jul 5, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit be3b166. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

Copy link

bundlemon bot commented Jul 5, 2024

BundleMon (Integration Projects)

Unchanged files (2)
Status Path Size Limits
Main bundles(Gzip)
hello-world-ng17/dist-integration/main.(hash)
.js
68.53KB +1%
Main bundles(Gzip)
hello-world-ng16/dist-integration/main.(hash)
.js
67.54KB +1%

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@profanis
Copy link
Contributor

profanis commented Jul 6, 2024

I published it locally, tested it, and it works fine

Copy link

codeclimate bot commented Jul 8, 2024

Code Climate has analyzed commit be3b166 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 84.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.4% (0.0% change).

View more on Code Climate.

@dmitry-stepanenko dmitry-stepanenko merged commit fc42360 into master Jul 8, 2024
13 checks passed
@dmitry-stepanenko dmitry-stepanenko deleted the ds/remove-local-ng-utils branch July 8, 2024 07:28
@markwhitfeld markwhitfeld added this to the v18.1.0 milestone Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞[BUG]: Fresh Angular 18 project and NGXS docs / Cannot find module standalone.js
3 participants