feat(store): add withExperimentalNgxsPendingTasks
#2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9397af7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
arturovt
force-pushed
the
feat/add-experimental-tasks
branch
2 times, most recently
from
65c9591
to
c1b2b89
Compare
BundleMon (Integration Projects)Unchanged files (2)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
In this commit, we provide the experimental app stability NGXS contributor as part of the code. This is a fundamental feature that probably shouldn't be included in recipes but should be part of our codebase. It is already being used in production by apps that utilize zoneless server-side rendering. We expose it through the `@ngxs/store/experimental` subpackage because exposing it from the core package would be a breaking change, as it uses the experimental pending tasks service introduced in Angular 18 (though we remain compatible with Angular 16).
arturovt
force-pushed
the
feat/add-experimental-tasks
branch
from
c1b2b89
to
ee5b476
Compare
arturovt
requested review from
markwhitfeld,
kuncevic,
Carniatto,
poloagustin,
joaqcid and
splincode
as code owners
markwhitfeld
approved these changes
Jul 11, 2024
|
Code Climate has analyzed commit 9397af7 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.4% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we provide the experimental app stability NGXS contributor as part
of the code. This is a fundamental feature that probably shouldn't be included in
recipes but should be part of our codebase. It is already being used in production
by apps that utilize zoneless server-side rendering. We expose it through the
@ngxs/store/experimentalsubpackage because exposing it from the core package wouldbe a breaking change, as it uses the experimental pending tasks service introduced in
Angular 18 (though we remain compatible with Angular 16).