Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix bundlemon reporting #2206

Merged
merged 1 commit into from
Aug 8, 2024
Merged

ci: fix bundlemon reporting #2206

merged 1 commit into from
Aug 8, 2024

Conversation

markwhitfeld
Copy link
Member

@markwhitfeld markwhitfeld commented Aug 8, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Bundlemon doesn't report on all built files

What is the new behavior?

The file paths are correct, so that we report on all necessary files.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link

nx-cloud bot commented Aug 8, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3b4c0c1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

Copy link

codeclimate bot commented Aug 8, 2024

Code Climate has analyzed commit 3b4c0c1 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.4% (0.0% change).

View more on Code Climate.

Copy link

bundlemon bot commented Aug 8, 2024

BundleMon

Files added (6)
Status Path Size Limits
fesm2022/ngxs-store.mjs
+97.8KB 100KB / +0.5%
fesm2022/ngxs-store-internals.mjs
+11.36KB 13KB / +0.5%
fesm2022/ngxs-store-internals-testing.mjs
+6.46KB 7KB / +0.5%
fesm2022/ngxs-store-operators.mjs
+6.22KB 7KB / +0.5%
fesm2022/ngxs-store-plugins.mjs
+2.04KB 3KB / +0.5%
fesm2022/ngxs-store-experimental.mjs
+1.4KB 2KB / +0.5%
Files removed (3)
Status Path Size Limits
fesm2015/ngxs-store.js
-94.14KB 125KB / +0.5%
fesm2015/ngxs-store-operators.js
-6.23KB 15KB / +0.5%
fesm2015/ngxs-store-internals.js
-3.57KB 20KB / +0.5%

Total files change +21.34KB +20.54%

Groups added (2)
Status Path Size Limits
@ngxs/store(esm2022)[gzip]
./esm2022/**/*.mjs
+217.15KB +1%
@ngxs/store(fesm2022)[gzip]
./fesm2022/*.mjs
+29.82KB +1%
Groups removed (3)
Status Path Size Limits
@ngxs/store(esm2015)[gzip]
./esm2015/**/*.js
-179.87KB +1%
@ngxs/store(umd)[gzip]
./bundles/*.umd.js
-36.45KB +1%
@ngxs/store(fesm2015)[gzip]
./fesm2015/*.js
-24.95KB +1%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

bundlemon bot commented Aug 8, 2024

BundleMon (NGXS Plugins)

Files added (9)
Status Path Size Limits
Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin.m
js
+4.15KB +0.5%
Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin.mjs
+3.2KB +0.5%
Plugins(fesm2022)[gzip]
websocket-plugin/fesm2022/ngxs-websocket-plug
in.mjs
+2.64KB +0.5%
Plugins(fesm2022)[gzip]
hmr-plugin/fesm2022/ngxs-hmr-plugin.mjs
+2.61KB +0.5%
Plugins(fesm2022)[gzip]
form-plugin/fesm2022/ngxs-form-plugin.mjs
+2.59KB +0.5%
Plugins(fesm2022)[gzip]
devtools-plugin/fesm2022/ngxs-devtools-plugin
.mjs
+2.23KB +0.5%
Plugins(fesm2022)[gzip]
logger-plugin/fesm2022/ngxs-logger-plugin.mjs
+2.09KB +0.5%
Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin-i
nternals.mjs
+875B +0.5%
Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin-int
ernals.mjs
+411B +0.5%
Files removed (16)
Status Path Size Limits
Plugins(umd)[gzip]
storage-plugin/bundles/ngxs-storage-plugin.um
d.js
-7.97KB +1%
Plugins(umd)[gzip]
router-plugin/bundles/ngxs-router-plugin.umd.
js
-7.19KB +1%
Plugins(umd)[gzip]
hmr-plugin/bundles/ngxs-hmr-plugin.umd.js
-6.89KB +1%
Plugins(umd)[gzip]
websocket-plugin/bundles/ngxs-websocket-plugi
n.umd.js
-6.79KB +1%
Plugins(fesm2015)[gzip]
storage-plugin/fesm2015/ngxs-storage-plugin.j
s
-3.7KB +1%
Plugins(umd)[gzip]
form-plugin/bundles/ngxs-form-plugin.umd.js
-3.29KB +1%
Plugins(fesm2015)[gzip]
router-plugin/fesm2015/ngxs-router-plugin.js
-2.92KB +1%
Plugins(umd)[gzip]
devtools-plugin/bundles/ngxs-devtools-plugin.
umd.js
-2.75KB +1%
Plugins(fesm2015)[gzip]
hmr-plugin/fesm2015/ngxs-hmr-plugin.js
-2.65KB +1%
Plugins(fesm2015)[gzip]
form-plugin/fesm2015/ngxs-form-plugin.js
-2.57KB +1%
Plugins(umd)[gzip]
logger-plugin/bundles/ngxs-logger-plugin.umd.
js
-2.53KB +1%
Plugins(fesm2015)[gzip]
websocket-plugin/fesm2015/ngxs-websocket-plug
in.js
-2.52KB +1%
Plugins(fesm2015)[gzip]
devtools-plugin/fesm2015/ngxs-devtools-plugin
.js
-2.17KB +1%
Plugins(fesm2015)[gzip]
logger-plugin/fesm2015/ngxs-logger-plugin.js
-2.01KB +1%
Plugins(umd)[gzip]
router-plugin/bundles/ngxs-router-plugin-inte
rnals.umd.js
-654B +1%
Plugins(fesm2015)[gzip]
router-plugin/fesm2015/ngxs-router-plugin-int
ernals.js
-406B +1%

Total files change -36.22KB -63.56%

Groups added (1)
Status Path Size Limits
All Plugins(fesm2022)[gzip]
./-plugin/fesm2022/.mjs
+20.76KB +0.5%
Groups removed (3)
Status Path Size Limits
All Plugins(esm2015)[gzip]
./-plugin/esm2015/**/.js
-109.06KB +1%
All Plugins(umd)[gzip]
./-plugin/bundles/.umd.js
-38.05KB +1%
All Plugins(fesm2015)[gzip]
./-plugin/fesm2015/.js
-18.93KB +1%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

bundlemon bot commented Aug 8, 2024

BundleMon (Integration Projects)

Unchanged files (3)
Status Path Size Limits
Main bundles(Gzip)
hello-world-ng18/dist-integration/browser/mai
n-(hash).js
71.66KB +1%
Main bundles(Gzip)
hello-world-ng17/dist-integration/main.(hash)
.js
68.55KB +1%
Main bundles(Gzip)
hello-world-ng16/dist-integration/main.(hash)
.js
67.57KB +1%

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@markwhitfeld markwhitfeld merged commit d756c2a into master Aug 8, 2024
14 checks passed
@markwhitfeld markwhitfeld deleted the ci/fix-bundlemon branch August 8, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants