Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add preview releases with pkg.pr.new #2216

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

dmitry-stepanenko
Copy link
Contributor

No description provided.

Copy link

nx-cloud bot commented Sep 8, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4e0e0f3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@dmitry-stepanenko dmitry-stepanenko force-pushed the ds/pkg.pr.new branch 3 times, most recently from 0c1ef0a to 76ed24f Compare September 8, 2024 11:34
Copy link

bundlemon bot commented Sep 9, 2024

BundleMon

Unchanged files (6)
Status Path Size Limits
fesm2022/ngxs-store.mjs
98.8KB 100KB / +0.5%
fesm2022/ngxs-store-internals.mjs
11.36KB 13KB / +0.5%
fesm2022/ngxs-store-internals-testing.mjs
6.83KB 7KB / +0.5%
fesm2022/ngxs-store-operators.mjs
6.22KB 7KB / +0.5%
fesm2022/ngxs-store-plugins.mjs
2.04KB 3KB / +0.5%
fesm2022/ngxs-store-experimental.mjs
1.4KB 2KB / +0.5%

No change in files bundle size

Unchanged groups (2)
Status Path Size Limits
@ngxs/store(esm2022)[gzip]
./esm2022/**/*.mjs
218.99KB +1%
@ngxs/store(fesm2022)[gzip]
./fesm2022/*.mjs
30.23KB +1%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

bundlemon bot commented Sep 9, 2024

BundleMon (NGXS Plugins)

Unchanged files (9)
Status Path Size Limits
Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin.m
js
4.15KB +0.5%
Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin.mjs
3.2KB +0.5%
Plugins(fesm2022)[gzip]
websocket-plugin/fesm2022/ngxs-websocket-plug
in.mjs
2.64KB +0.5%
Plugins(fesm2022)[gzip]
hmr-plugin/fesm2022/ngxs-hmr-plugin.mjs
2.61KB +0.5%
Plugins(fesm2022)[gzip]
form-plugin/fesm2022/ngxs-form-plugin.mjs
2.59KB +0.5%
Plugins(fesm2022)[gzip]
devtools-plugin/fesm2022/ngxs-devtools-plugin
.mjs
2.23KB +0.5%
Plugins(fesm2022)[gzip]
logger-plugin/fesm2022/ngxs-logger-plugin.mjs
2.09KB +0.5%
Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin-i
nternals.mjs
875B +0.5%
Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin-int
ernals.mjs
411B +0.5%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
All Plugins(fesm2022)[gzip]
./-plugin/fesm2022/.mjs
20.76KB +0.5%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

bundlemon bot commented Sep 9, 2024

BundleMon (Integration Projects)

Unchanged files (3)
Status Path Size Limits
Main bundles(Gzip)
hello-world-ng18/dist-integration/browser/mai
n-(hash).js
71.66KB +1%
Main bundles(Gzip)
hello-world-ng17/dist-integration/main.(hash)
.js
68.56KB +1%
Main bundles(Gzip)
hello-world-ng16/dist-integration/main.(hash)
.js
67.58KB +1%

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Member

@markwhitfeld markwhitfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, except I don't see a generated comment in the PR.
Not sure what is needed for this.

Copy link

pkg-pr-new bot commented Sep 9, 2024

Open in Stackblitz

@ngxs/form-plugin

yarn add https://pkg.pr.new/@ngxs/form-plugin@2216.tgz

@ngxs/devtools-plugin

yarn add https://pkg.pr.new/@ngxs/devtools-plugin@2216.tgz

@ngxs/hmr-plugin

yarn add https://pkg.pr.new/@ngxs/hmr-plugin@2216.tgz

@ngxs/router-plugin

yarn add https://pkg.pr.new/@ngxs/router-plugin@2216.tgz

@ngxs/storage-plugin

yarn add https://pkg.pr.new/@ngxs/storage-plugin@2216.tgz

@ngxs/store

yarn add https://pkg.pr.new/@ngxs/store@2216.tgz

@ngxs/websocket-plugin

yarn add https://pkg.pr.new/@ngxs/websocket-plugin@2216.tgz

commit: 4e0e0f3

Copy link

codeclimate bot commented Sep 9, 2024

Code Climate has analyzed commit 4e0e0f3 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.3% (0.0% change).

View more on Code Climate.

@dmitry-stepanenko
Copy link
Contributor Author

dmitry-stepanenko commented Sep 9, 2024

@markwhitfeld I force-pushed the branch and it's posting the comment now. It posts the link with PR number instead of commit hash, that's how it works, however both hash and PR number seem to be installable..

@markwhitfeld markwhitfeld changed the title chore: add preview releases with pkg.pr.new ci: add preview releases with pkg.pr.new Sep 9, 2024
@markwhitfeld
Copy link
Member

markwhitfeld commented Sep 9, 2024

Great work!!!!
I wonder why it is showing the example using yarn add and not npm i.
Not an issue, just find it interesting that it seems to pick up the repository preference.

@markwhitfeld markwhitfeld merged commit bd43d33 into master Sep 9, 2024
16 checks passed
@markwhitfeld markwhitfeld deleted the ds/pkg.pr.new branch September 9, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants