Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update migration entry points #448

Merged
merged 4 commits into from
Aug 2, 2024
Merged

Conversation

jdegand
Copy link
Contributor

@jdegand jdegand commented Jul 14, 2024

Closes #447.

Copy link
Collaborator

@nartc nartc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this wasn't the cause. Check the PageTitle component and update the sourceCodeUrl there.

@jdegand
Copy link
Contributor Author

jdegand commented Jul 15, 2024

Change this https://github.com/nartc/ngxtension-platform/tree/main/libs/ngxtension/${entryPoint} to https://github.com/nartc/ngxtension-platform/tree/main/libs/${entryPoint} and add folder to all other entry points ?

I think bundleJsUrl will also have to be updated as well from https://deno.bundlejs.com?q=ngxtension/${entryPoint}&treeshake= to https://deno.bundlejs.com?q=${entryPoint}&treeshake=.

@nartc
Copy link
Collaborator

nartc commented Jul 15, 2024

@jdegand

  • Change https://github.com/nartc/ngxtension-platform/tree/main/libs/ngxtension/${entryPoint} to https://github.com/ngxtension/ngxtension-platform/tree/main/libs/ngxtension/${entryPoint}
  • The bundleJsUrl is fine because it reaches out to npmjs instead of repo's file structure.

@jdegand
Copy link
Contributor Author

jdegand commented Jul 15, 2024

I went a different way, but I see more of what you want. It would be less changes, but you would have to use ../ to access files outside the ngxtension folder.

Other issues I noticed: Gesture vs Gestures, if-validator does not have a readme file.

@nartc
Copy link
Collaborator

nartc commented Jul 15, 2024

@jdegand as for missing readme files, I'd like a separate PR if possible. Thanks!!

@nartc nartc merged commit 9d55adb into ngxtension:main Aug 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entry Points of all migrations are wrong
2 participants