Generate all mappings in the order they were declared #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HermanSchoenfeld great work! thanks for this... I will have a look tomorrow. 🥇 I was thinking what level of backward compatibility will this have... |
jrgcubano
requested changes
Dec 21, 2018
| Dictionary.TryGetValue(key, out value); | ||
| var removed = Dictionary.Remove(key); | ||
| if (removed) | ||
| //OnCollectionChanged(NotifyCollectionChangedAction.Remove, new KeyValuePair<TKey, TValue>(key, value)); |
There was a problem hiding this comment.
Please remove this unused comment.
There was a problem hiding this comment.
Fixed, with other cleanup.
jrgcubano
approved these changes
Dec 29, 2018
hazzik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a long-awaited feature for many users. Prior pull request had unit test errors. The code has been re-done, all tests pass and has been QA'd on my end.
All mappings are DB-generated in the order they were declared, which is useful for cosmetic purposes as well as some legacy compatibility use-cases.