Use pattern matching to check and perform type conversion #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![deepsource-autofix[bot]](https://avatars.githubusercontent.com/in/57168?s=60&v=4){kind=small}
hazzik
reviewed
Oct 24, 2022
hazzik
reviewed
Oct 24, 2022
hazzik
reviewed
Oct 24, 2022
hazzik
reviewed
Oct 24, 2022
| SubclassMapping subclassMapping; | ||
| var tempSubClassMap = mapping as SubclassMapping; | ||
| if(!tempIsNull && tempMapping.IsUnionSubclass || tempSubClassMap != null && tempSubClassMap.SubclassType == SubclassType.UnionSubclass) | ||
| if(!tempIsNull && tempMapping.IsUnionSubclass || mapping is SubclassMapping tempSubClassMap&& tempSubClassMap.SubclassType == SubclassType.UnionSubclass) |
There was a problem hiding this comment.
@pawan-deepsource this is failing with:
C:\projects\fluent-nhibernate\src\FluentNHibernate\Automapping\AutoMapper.cs(86,45): error CS0165: Use of unassigned local variable 'tempSubClassMap' [C:\projects\fluent-nhibernate\src\FluentNHibernate\FluentNHibernate.csproj]
C:\projects\fluent-nhibernate\src\FluentNHibernate\Automapping\AutoMapper.cs(86,45): error CS0165: Use of unassigned local variable 'tempSubClassMap' [C:\projects\fluent-nhibernate\src\FluentNHibernate\FluentNHibernate.csproj]
C:\projects\fluent-nhibernate\src\FluentNHibernate\Automapping\AutoMapper.cs(86,45): error CS0165: Use of unassigned local variable 'tempSubClassMap' [C:\projects\fluent-nhibernate\src\FluentNHibernate\FluentNHibernate.csproj]
There was a problem hiding this comment.
This case is actually a false positive since there's a reference to tempSubClassMap after the cast on L86. Autofix wouldn't have failed if the check hadn't fired in the first place. IMO, it was the check that misled Autofix and that's where the problem is. Tracking it internally.
Edit: Will also ensure that the whitespace and formatting is preserved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.